From d02c0838981acc879fc7b246d3a5db57a9384724 Mon Sep 17 00:00:00 2001
From: GauthierWebDev <gauthier@gauthierdaniels.fr>
Date: Tue, 22 Apr 2025 13:14:10 +0200
Subject: [PATCH] refactor: Improve code readability and maintainability

---
 app/components/QuickLinks.tsx |  4 +--
 app/services/DocCache.ts      | 67 ++++++++++++++++++++++++-----------
 2 files changed, 48 insertions(+), 23 deletions(-)

diff --git a/app/components/QuickLinks.tsx b/app/components/QuickLinks.tsx
index 0ba1139..b36fc91 100644
--- a/app/components/QuickLinks.tsx
+++ b/app/components/QuickLinks.tsx
@@ -37,7 +37,7 @@ QuickLinks.QuickLink = (props: QuickLinkProps) => (
 		<div class="relative overflow-hidden rounded-xl p-6">
 			<Icon icon={props.icon} color="blue" class="h-8 w-8" />
 
-			<h2 class="mt-4 font-display text-base text-slate-900">
+			<h2 class="mt-4 font-display text-base text-slate-900 leading-5">
 				<Link href={props.href}>
 					<span class="absolute -inset-px rounded-xl" />
 					{props.title}
@@ -45,7 +45,7 @@ QuickLinks.QuickLink = (props: QuickLinkProps) => (
 			</h2>
 
 			{props.lastEdited && (
-				<p class="-mt-2 italic mb-2 text-xs text-slate-500">
+				<p class="mt-2 mb-4 italic text-xs text-slate-500">
 					<span class="font-semibold">Dernière modification :</span>{" "}
 					<time datetime={props.lastEdited.toISOString()}>
 						{props.lastEdited.toLocaleDateString("fr-FR", {
diff --git a/app/services/DocCache.ts b/app/services/DocCache.ts
index 86d971d..8e45005 100644
--- a/app/services/DocCache.ts
+++ b/app/services/DocCache.ts
@@ -230,30 +230,55 @@ class DocCache {
 			...customConfig,
 		};
 
+		const checkIfIncludedBasePath = (doc: SectionCache) => {
+			if (config.includedBasePaths.length > 0) {
+				return config.includedBasePaths.some((basePath) => {
+					return doc.filePath.startsWith(basePath);
+				});
+			}
+
+			return true;
+		};
+
+		const checkIfExcludedBasePaths = (doc: SectionCache) => {
+			if (config.excludedBasePaths.length > 0) {
+				return !config.excludedBasePaths.some((basePath) => {
+					return doc.filePath.startsWith(basePath);
+				});
+			}
+
+			return true;
+		};
+
+		const checkIfIncludedFileNames = (doc: SectionCache) => {
+			if (config.includedFileNames.length > 0) {
+				return config.includedFileNames.some((fileName) => {
+					return doc.filePath.includes(fileName);
+				});
+			}
+
+			return true;
+		};
+
+		const checkIfExcludedFileNames = (doc: SectionCache) => {
+			if (config.excludedFileNames.length > 0) {
+				return !config.excludedFileNames.some((fileName) => {
+					return doc.filePath.includes(fileName);
+				});
+			}
+
+			return true;
+		};
+
 		const sortedDocs = Array.from(this.cache.values())
 			.sort((a, b) => b.lastEdit.getTime() - a.lastEdit.getTime())
 			.filter((doc) => {
-				if (config.includedBasePaths.length > 0) {
-					return config.includedBasePaths.some((basePath) => {
-						return doc.filePath.startsWith(basePath);
-					});
-				}
-				if (config.excludedBasePaths.length > 0) {
-					return !config.excludedBasePaths.some((basePath) => {
-						return doc.filePath.startsWith(basePath);
-					});
-				}
-				if (config.includedFileNames.length > 0) {
-					return config.includedFileNames.some((fileName) => {
-						return doc.filePath.includes(fileName);
-					});
-				}
-				if (config.excludedFileNames.length > 0) {
-					return !config.excludedFileNames.some((fileName) => {
-						return doc.filePath.includes(fileName);
-					});
-				}
-				return true;
+				return [
+					checkIfIncludedBasePath(doc),
+					checkIfExcludedBasePaths(doc),
+					checkIfIncludedFileNames(doc),
+					checkIfExcludedFileNames(doc),
+				].every((check) => check === true);
 			});
 
 		if (config.limit > 0) return sortedDocs.slice(0, config.limit);