From 668f73069218a4477ce84a72c67e879c089a22c4 Mon Sep 17 00:00:00 2001 From: GauthierWebDev Date: Fri, 18 Apr 2025 18:41:40 +0200 Subject: [PATCH] fix: Update findNavigationLink parameter to optional --- app/lib/navigation.ts | 2 +- app/pages/docs/+route.ts | 2 +- app/services/DocsService.ts | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/lib/navigation.ts b/app/lib/navigation.ts index a74b5e2..a970b4c 100644 --- a/app/lib/navigation.ts +++ b/app/lib/navigation.ts @@ -133,7 +133,7 @@ export function doesLinkSubitemExist(link: NavigationLink, subitemHref: string): return link.subitems.some((subitem) => subitem.href === subitemHref); } -export function findNavigationLink(namespace: string, href: string): NavigationLink | undefined { +export function findNavigationLink(namespace: string, href?: string): NavigationLink | undefined { const currentUrl = `/${namespace}/${href}`.replace(/\/+/g, "/").replace(/\/$/, ""); const foundLink = navigation diff --git a/app/pages/docs/+route.ts b/app/pages/docs/+route.ts index 6d0b182..1552b94 100644 --- a/app/pages/docs/+route.ts +++ b/app/pages/docs/+route.ts @@ -4,7 +4,7 @@ const routeRegex = /^\/docs\/(.*)$/; export function route(pageContext: PageContext) { if (pageContext.urlPathname === "/docs") { - return { routeParams: { key: "documentations" } }; + return { routeParams: { key: "index" } }; } const match = pageContext.urlPathname.match(routeRegex); diff --git a/app/services/DocsService.ts b/app/services/DocsService.ts index 274424f..53a534f 100644 --- a/app/services/DocsService.ts +++ b/app/services/DocsService.ts @@ -152,14 +152,12 @@ class DocsService { }; } - public async getDoc(namespace: "root"): Promise; - public async getDoc(namespace: "docs" | "certifications", key: string): Promise; public async getDoc(namespace: "root" | "docs" | "certifications", key?: string): Promise { try { await this.fetchDocs(); let doc: DocData | undefined; - if (namespace === "root") { + if (namespace === "root" || key === "index") { doc = this.getFromCache(`/${namespace}`); } else { doc = this.getFromCache(`/${namespace}/${key}`);